fix(graphql): filter on collections not working #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch filtering doesn't work on collections. The following
query returns all collections instead of the one that's filtered for:
{
collections(where: { name: { eq: "test"}}) {
data {
name
id
hypercerts {
hypercert_id
}
}
}
}
The same holds true for ids.
Tests would complain when the Alchemy env var isn't found. The tests shouldn't even need it. This most likely came to be when the RPC URL building was changed and this test was missed. The new mocks catch that oversight.
Adding code inside of baseTypes.ts requires us to lower the coverage thresholds as it's notoriously difficult to test.
pheuberger
force-pushed
the
fix-collections-graphql-filtering
branch
from
2f0b670 to
6af04d5
Compare
This was
linked to
issues
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch filtering doesn't work on collections. The following query returns all collections instead of the one that's filtered for:
{ collections(where: { name: { eq: "test"}}) { data { name id hypercerts { hypercert_id } } } }The same holds true for ids.